Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect base when structural inheritance exists #2

Closed
brollb opened this issue Oct 18, 2021 · 0 comments
Closed

Incorrect base when structural inheritance exists #2

brollb opened this issue Oct 18, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@brollb
Copy link
Collaborator

brollb commented Oct 18, 2021

The base is incorrect when using structural inheritance. It appears to stem from the use of getPointerPath rather than getBase internally. I suspect getPointerPath is resolving the pointer name to the one inherited from the base type (in this case, this skips the actual base to get the base of the base).
@brollb brollb added the bug Something isn't working label Oct 18, 2021
@brollb brollb closed this as completed in 233c19e Oct 18, 2021
brollb added a commit that referenced this issue Oct 18, 2021
@brollb
Merge pull request #3 from deepforge-dev/2-incorrect-base-struct-inherit
a7134ad 
Resolve base correctly when using structural inheritance. Fixes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brollb