Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up @guid resolution #21

Closed
brollb opened this issue Feb 15, 2022 · 1 comment
Closed

Speed up @guid resolution #21

brollb opened this issue Feb 15, 2022 · 1 comment

Comments

@brollb
Copy link
Collaborator

brollb commented Feb 15, 2022

There are a few options that could speed up @guid resolution:

  • caching nodes by GUID while searching for a node (reusing this for subsequent resolutions)
  • incorporating heuristics into the search such as starting at the current node. This could be trickier to track (fully) explored paths when combined with the previous comment.
@brollb
Copy link
Collaborator Author

brollb commented Feb 15, 2022

For reference, https://github.com/deepforge-dev/webgme-json-importer/blob/master/src/common/JSONImporter.js#L746-L750

brollb added a commit that referenced this issue Apr 4, 2022
@brollb
Add caching to @Guid resolution. Closes #21
a95682e
@brollb brollb closed this as completed in a853f7f Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brollb