Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow picking keys during export #34

Closed
umesh-timalsina opened this issue Sep 6, 2022 · 1 comment
Closed

Allow picking keys during export #34

umesh-timalsina opened this issue Sep 6, 2022 · 1 comment
Assignees

Comments

@umesh-timalsina
Copy link
Contributor

The WJI format can get quite verbose and the toJSON sometimes contains properties which are not necessarily relavent to the client application. Hence, can the signature toJSON(node, shallow) be modified to toJSON(node, attributes=['children', 'pointers', ....])? I am fine with the previous signature or a signature like toJSON(node, omitAttributes=['children', 'pointers', ...])

@umesh-timalsina umesh-timalsina changed the title Allow picking keys during import Allow picking keys during export Sep 6, 2022
@brollb
Copy link
Collaborator

brollb commented Sep 6, 2022

This sounds good but it might be nice to use a Set rather than an index as I would expect it to have better performance than using an array (and the position doesn't have any meaning here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants