Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch function is not working with just changesets. #40

Closed
umesh-timalsina opened this issue Sep 26, 2022 · 1 comment
Closed

Patch function is not working with just changesets. #40

umesh-timalsina opened this issue Sep 26, 2022 · 1 comment
Assignees
@umesh-timalsina
Labels
bug Something isn't working

Comments

@umesh-timalsina
Copy link
Contributor

umesh-timalsina commented Sep 26, 2022 •
edited
Loading

The patch function in WJI when provided with node and ChangeSets array tries to apply all the changes to the top level node rather than properly resolving its children and applying changes throughout the subtree.
@umesh-timalsina umesh-timalsina self-assigned this Sep 26, 2022
@brollb
Copy link
Collaborator

brollb commented Sep 26, 2022

Can you make sure to add a test for this?

umesh-timalsina added a commit that referenced this issue Sep 26, 2022
@umesh-timalsina
Added test to reproduce #40
755446d
@umesh-timalsina umesh-timalsina added the bug Something isn't working label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umesh-timalsina umesh-timalsina

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brollb @umesh-timalsina