Rewrite JSONImporter in TypeScript. Closes #30 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umesh-timalsina
changed the title
TypeScript
umesh-timalsina
changed the title
brollb
requested changes
Sep 30, 2022
| return [ | ||
| new NodeChangeSet( | ||
| nodePath, | ||
| childState.id || '', |
There was a problem hiding this comment.
This probably shouldn't use '' since that is actually used for the root node. undefined would probably be better.
| resolvedSelectors.record(parentPath, alternateSelector, created); | ||
| } | ||
| const nodeState = await this.toJSON(created, new OmittedProperties(['children'])); | ||
| const changes = gmeDiff(nodeState, state); |
There was a problem hiding this comment.
I still don't like diffing in the patch fn if it can be avoided but this should be explored in a different PR
Comment on lines
12
to
27
| super(args); | ||
| const invalidProperties = INVALID_PROPS.filter(prop => this.has(prop)); | ||
|
|
||
| if(invalidProperties.length) { | ||
| throw new Error(`Invalid properties to omit: ${invalidProperties.join(', ')}`); | ||
| } | ||
| } | ||
|
|
||
| withRelatedProperties(): OmittedProperties { | ||
| const relatedProps = Object.keys(RELATED_PROPERTIES) | ||
| .filter(key => this.has(key)) | ||
| .flatMap(key => RELATED_PROPERTIES[key]); | ||
|
|
||
| relatedProps.forEach(dep => this.add(dep)); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
We should add a code formatter - like prettier - as a githook (not in this PR).
umesh-timalsina
force-pushed
the
30-ts-refactor
branch
from
0253a5c
to
6dce159
Compare
brollb
approved these changes
Oct 4, 2022
|
Nice work, @umesh-timalsina! There are a few things left for other PRs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.