Import golden-layout as a package

[mofojed]

We currently have a fork of golden-layout: https://github.com/illumon-public/golden-layout/

However, the newest version of GoldenLayout dropped React support: https://github.com/golden-layout/golden-layout

They recommend switching the FlexLayout, but there's issues in FlexLayout that @dsmmcken has already fixed (such as handling long tab names, overflow when you have more tabs in the stack that can be shown that doesn't suck, being able to drag a tab and have the edge of the stack scroll, a tab placeholder that represents the actual content size, etc).

Since our previous fork will never be able to merge back to their fork, we may as well import it into our repo. We should also publish an actual package with an updated version, rather than referencing it by SHA/old repo.

Eventually we should either switch to FlexLayout (and fix the above issues that we've already fixed), or rewrite our golden-layout without jquery.

[mofojed]

We're going to need this in a separate repo - may as well just fork the existing repo and push it under our org. I don't think there's any advantage to having it as a folder within our web/client-ui repo.

[dsmmcken]

My opinion is that it would be more friction to have this separate, and we should do the work to bring it under one build process.

[mofojed]

Golden-Layout is MIT license, we're going Apache for web-client-ui and Deephaven license for core to start, one license per repo, we'll need this in a separate repo.

[dsmmcken]

Does that matter for repos other than core?

…

On Thu., Apr. 29, 2021, 4:53 p.m. Mike Bender, ***@***.***> wrote: Golden-Layout is MIT license, we're going Apache for web-client-ui and Deephaven license for core to start, one license per repo, we'll need this in a separate repo. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/deephaven/core/issues/198#issuecomment-829588843>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMA2W2U3BFKLAJQLND36M3TLHBODANCNFSM4ZV4MWOA> .

[mofojed]

I think it will be for all repos under the Deephaven org?
Which friction are you worried about having it separate? Setting up npm link for development?

[mofojed]

Going fork will require deephaven/deephaven-core#491

[dsmmcken]

I think it really only matters for core to have a clean license, the rest aren't the focus of attention. If client-ui has a mixed licensed file, who cares. Unlike core, the packages are still distributed individually, where licensing is clear.

We most definitely currently experience the friction of it being a separate repo, and have been less likely to contribute to it, and less likely to but the same review on it.