Skip to content

Commit

Permalink
Mark grpc dependencies as api (#1805)
Browse files Browse the repository at this point in the history
Fixes #1804
  • Loading branch information
devinrsmith authored Jan 14, 2022
1 parent 647d4b8 commit ba6f16a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 14 deletions.
4 changes: 1 addition & 3 deletions java-client/example-utilities/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@ plugins {
dependencies {
api 'info.picocli:picocli:4.6.1'
api project(':java-client-session')

Classpaths.inheritGrpcPlatform(project, 'api')
api 'io.grpc:grpc-core'
api 'io.grpc:grpc-api'
}
5 changes: 2 additions & 3 deletions java-client/session-dagger/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ description = 'The Deephaven client session dagger library'

dependencies {
api project(':java-client-session')

Classpaths.inheritGrpcPlatform(project, 'implementation')
implementation 'io.grpc:grpc-api'
api 'io.grpc:grpc-api'
implementation project(':proto:proto-backplane-grpc')

Classpaths.inheritDagger(project)

Expand Down
7 changes: 3 additions & 4 deletions java-client/session/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ description = 'The Deephaven client session library'

dependencies {
api project(':qst')
api project(':proto:proto-backplane-grpc')
api project(':uri')

Classpaths.inheritGrpcPlatform(project, 'implementation')
implementation "io.grpc:grpc-stub"
api 'io.grpc:grpc-api'
// TODO(deephaven-core#1783): Make proto-backplane-grpc implementation dependency
api project(':proto:proto-backplane-grpc')

Classpaths.inheritImmutables(project)

Expand Down
8 changes: 4 additions & 4 deletions proto/proto-backplane-grpc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ dependencies {
// This should be implementation, if listed at all, at least once we have own own version management
api "com.google.protobuf:protobuf-java:${protobufVersion}"

Classpaths.inheritGrpcPlatform(project, 'implementation')
implementation "io.grpc:grpc-protobuf"
implementation "io.grpc:grpc-api"
implementation "io.grpc:grpc-stub"
Classpaths.inheritGrpcPlatform(project, 'api')
api 'io.grpc:grpc-protobuf'
api 'io.grpc:grpc-api'
api 'io.grpc:grpc-stub'

runtimeOnly "io.netty:netty-tcnative-boringssl-static:${boringSslVersion}"

Expand Down

0 comments on commit ba6f16a

Please sign in to comment.