Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create appropriate standards around TODO #87

Closed
devinrsmith opened this issue Feb 23, 2021 · 4 comments
Closed

Create appropriate standards around TODO #87

devinrsmith opened this issue Feb 23, 2021 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@devinrsmith
Copy link
Member

When is it applicable? How should it be done? Should they link to a ticket (just a number, or a url)? If a corresponding TODO issue is closed, should the TODO be deleted? etc.

@devinrsmith devinrsmith added the documentation Improvements or additions to documentation label Feb 23, 2021
@devinrsmith devinrsmith added this to the Finishing Touches milestone Feb 23, 2021
@mofojed
Copy link
Member

mofojed commented Apr 19, 2021

TODO's will have the standard TODO format. Link just the ticket number, and the repo name if it's in a different repo. Eg. TODO: #87 Create appropriate standards around TODO Upon merge of PR containing TODOs, a permalink to the TODO in the code is added as a comment on the ticket (could that be automated?). Closing the ticket should address those linked TODOs, and therefore delete those TODO lines.

@mofojed
Copy link
Member

mofojed commented May 26, 2021

The GitHub plugin for VSCode also has "Create Issue Triggers" that allow for quick creation of an issue when typing "TODO", and it automatically adds the issue number in your code, and adds a link to that code in the ticket. An example ticket: deephaven/web-client-ui#45

@devinrsmith
Copy link
Member Author

I'm confused - this is only for VSCode though, yeah? Not for how we should reference GH issues in code?

@mofojed
Copy link
Member

mofojed commented May 26, 2021

VSCode creates the issue in GitHub. If you're not using the plugin and the ticket does not already exist, then create the ticket using the normal New Issue flow, and reference it with the #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants