Nightly / fix nightly check #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4a2a992.
…rties when appropriate.
* upstream/main: Move slow tests (>= 10 seconds) to the nightly check, fixes deephaven#606 (deephaven#616) Set ownership of DevRel relevant files (deephaven#625) Fix context leak in RedirectedColumnSource.RedirectionFillFrom (deephaven#619) Followup to review comments. Followup to review comments. Removed some unused code. Ensure generated formula code handles prev correctly for i,ii in ticking tables. Fixes deephaven#544 Produce the right exception, instead of returning null, on invalid arguments for calls to SortedRanges.invert. Towards deephaven#544.
* upstream/main: Try to tune down logging from SSA and SSM unit tests (deephaven#635) Add the new documentation site to the readme (deephaven#633)
This reverts commit feaf3a0.
|
nightly CI passing, see run here https://github.com/devinrsmith/deephaven-core/actions/runs/861612522 |
This was referenced May 20, 2021
Closed
…-check * upstream/main: Check documentation labels, fixes deephaven#627 (deephaven#671) Fix integer overflow in SortedRanges.invertOnNew. Fixes deephaven#666. (deephaven#667) Fix integer overflow in SortedRanges.subRangeByPos. Fixes deephaven#664 (deephaven#665) Deploy example scripts and data (deephaven#562) port the numba integration prototype from Enterprise to OSS, fixes feature-523 (deephaven#638) Fix IllegalStateException in TwoValuesContainer triggered from Index.insert(Chunk). Fixes deephaven#652. (deephaven#653) Javadoc search (deephaven#645) Support for jpy integration junit tests (deephaven#632) Populate snapshot request in js api, handle optional left table (deephaven#648) Fix a link formatting bug in CONTRIBUTING.md (deephaven#629)
rcaudy
reviewed
May 26, 2021
| @@ -1,6 +1,13 @@ | |||
| # TODO (deephaven-core#639): Customize gradle settings per-CI job | |||
There was a problem hiding this comment.
Is this our "todo standard"? I've been doing TODO (deephaven/deephaven-core/issues/#).
There was a problem hiding this comment.
We don't have this documented in our CONTRIBUTING.md guide or in our wiki anywhere... @chipkent to decide if it should be documented anywhere.
When discussing previously, we had settled on just the issue number if in the same repo, or repo and issue number if in a different repo. In this case, it would be # TODO: #639 .... These comments are on issue #87 .
Also the GitHub plugin for VSCode has a handy trigger that will automatically create issues for you, and link them back to the code: https://code.visualstudio.com/docs/editor/github#_creating-issues
I'm not seeing a similar plugin for IntelliJ.
ClientSupport/src/test/java/io/deephaven/treetable/TreeSnapshotQueryTest.java
Show resolved
Hide resolved
DB-test/src/test/java/io/deephaven/db/util/TestWorkerPythonEnvironment.java
Outdated
Show resolved
Hide resolved
ClientSupport/src/main/java/io/deephaven/treetable/AbstractTreeSnapshotImpl.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/utils/TableToolsMergeHelper.java
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/v2/sources/UnionSourceManager.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
May 26, 2021
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this pull request
May 28, 2021
* tag 'v0.0.2': (29 commits) Move label information to CI remove labels try pushing to my own org try actor Upgrade to GITHUB_TOKEN instead of PAT Explicit about docker/build-push-action version Explicit about docker/login-action version Explicit about docker/setup-buildx-action version Remove extraneous comments Update docker metadata steps Remove top level building of deephaven-jpy in CI, is handled implicitly in grpc-api step Fix nightly check (deephaven#641) Address `QueryTableTest.testReverseClipping` table reachability bug, and unit test listeners using `RetentionCache` (deephaven#644) Rename symbols in .proto files to follow standard conventions (deephaven#674) Check documentation labels, fixes deephaven#627 (deephaven#671) Fix integer overflow in SortedRanges.invertOnNew. Fixes deephaven#666. (deephaven#667) Fix integer overflow in SortedRanges.subRangeByPos. Fixes deephaven#664 (deephaven#665) Deploy example scripts and data (deephaven#562) port the numba integration prototype from Enterprise to OSS, fixes feature-523 (deephaven#638) Fix IllegalStateException in TwoValuesContainer triggered from Index.insert(Chunk). Fixes deephaven#652. (deephaven#653) ...
jmao-denver
pushed a commit
to jmao-denver/deephaven-core
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.