Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable envoy websocket timeout #1139

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

niloc132
Copy link
Member

This is analogous to how we disable grpc stream timeout, and should
possibly be reconsidered in the future.

Fixes #1131

This is analogous to how we disable grpc stream timeout, and should
possibly be reconsidered in the future.

Fixes deephaven#1131
@niloc132 niloc132 added jsapi release blocker A bug/behavior that puts is below the "good enough" threshold to release. labels Aug 26, 2021
@niloc132 niloc132 added this to the Aug 2021 milestone Aug 26, 2021
@niloc132 niloc132 requested a review from mofojed August 26, 2021 19:08
@niloc132 niloc132 self-assigned this Aug 26, 2021
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, seemed to work fine

@niloc132 niloc132 merged commit 590a746 into deephaven:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jsapi NoDocumentationNeeded release blocker A bug/behavior that puts is below the "good enough" threshold to release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection failure received after leaving page idle for a few minutes
2 participants