Added the csv module and the dependent ones, fixes #1391 #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmao-denver
commented
Oct 25, 2021
jmao-denver
commented
- added the csv module with read csv support
- added the dtypes module that unifies qst types and plain DH types and presents the users with a familiar interface (similar to numpy and tensor, and traditional DB)
- added skeleton Table and Column classes
- added dherror module with the custom Exception class DHError that extracts the root cause from the embedded Java/Python exception stack from JPY, and also provides a compact traceback, to support easier debugging
- added integrated unit test suite for read csv
- added Docstrings for the public components
devinrsmith
previously requested changes
Oct 25, 2021
chipkent
requested changes
Oct 25, 2021
chipkent
requested changes
Oct 27, 2021
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
chipkent
requested changes
Oct 27, 2021
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
chipkent
approved these changes
Oct 27, 2021
jmao-denver
dismissed
devinrsmith’s stale review
should have addressed in later commits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.