Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in avro options "mapping" and "mapping_only" for ConsumeKafka.py. #1656

Merged

Conversation

jcferretti
Copy link
Member

Thanks to Jianfeng for finding this was broken. Manual test showing this works now:

Deephaven - Google Chrome_139

The share_price_record schema is shown below:

cfs@erke 23:16:20 ~/dh/oss3/deephaven-core
$ cat redpanda/examples/avro/share_price.json 
{ "type" : "record",
  "namespace" : "io.deephaven.examples",
  "name" : "share_price",
  "fields" : [
      { "name" : "Symbol", "type" : "string" },
      { "name" : "Side",   "type" : "string" },
      { "name" : "Qty",    "type" : "int"    },
      { "name" : "Price",  "type" : "double" }
  ]
}

Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approve the PR based on the fact that all of the changes are meant to add robustness to the code. I don't think it is a good investment of my time to try it with any amount of testing myself to verify the changes as the author clearly stated that he had to manually test the changes and we have CI checks to prevent regression.

@jmao-denver jmao-denver merged commit d20d930 into deephaven:main Dec 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2021
@jcferretti jcferretti deleted the cfs-fix-pyconsumekafka-mapping-0 branch December 9, 2021 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants