Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Python sort syntax. #1669

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Fixed Python sort syntax. #1669

merged 2 commits into from
Dec 9, 2021

Conversation

chipkent
Copy link
Member

@chipkent chipkent commented Dec 9, 2021

Fixed Python sort syntax. as_list did not work as intended.

Resolves #1668

@chipkent chipkent added this to the Nov 2021 milestone Dec 9, 2021
@chipkent chipkent requested a review from jmao-denver December 9, 2021 15:42
@chipkent chipkent self-assigned this Dec 9, 2021
jmao-denver
jmao-denver approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change puts the functionality in the right place and reduces redundancy.

@chipkent chipkent merged commit 4e1524b into deephaven:main Dec 9, 2021
@chipkent chipkent deleted the 1668_python_sort_syntax_bug branch December 9, 2021 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

Assignees

@chipkent chipkent

Labels
DocumentationNeeded python python-server-side
Projects
None yet
Milestone
Nov 2021
Development

Successfully merging this pull request may close these issues.

Python sort syntax with as_list is not functioning
2 participants
@chipkent @jmao-denver