Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special cases that need no permutation. #1737

Merged
merged 11 commits into from
Dec 30, 2021
Merged

Special cases that need no permutation. #1737

merged 11 commits into from
Dec 30, 2021

Conversation

cpwright
Copy link
Contributor

No description provided.

@cpwright cpwright marked this pull request as ready for review December 28, 2021 20:49
rcaudy
rcaudy approved these changes Dec 30, 2021
View reviewed changes
.../table/src/main/java/io/deephaven/engine/table/impl/by/ChunkedOperatorAggregationHelper.java
@@ -1656,7 +1657,7 @@ private static void initialBucketedKeyAddition(QueryTable withView,
if (ii == inputSlot) {
if (!permute) {
valueChunks[inputSlot] = getChunk(ac.inputColumns[ii], getContexts[ii], chunkOk, usePrev);
} else {
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray space?

@cpwright cpwright merged commit 03c26a8 into deephaven:main Dec 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees
No one assigned
Labels
NoDocumentationNeeded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpwright @rcaudy