Add ApplicationService with subscribeToFields to java-client-session #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
feature request
niloc132
reviewed
Dec 23, 2021
| @@ -10,6 +10,7 @@ dependencies { | |||
|
|
|||
| Classpaths.inheritGrpcPlatform(project, 'implementation') | |||
| implementation 'io.grpc:grpc-core' | |||
| implementation 'io.grpc:grpc-netty' | |||
There was a problem hiding this comment.
It seems odd that this wasn't required before now, in that it might be a hole in the java-client-session api to not convey this, or this might be a more in-depth example than normally goes in this project?
There was a problem hiding this comment.
Sorry, I need to change this to runtimeOnly.
There was a problem hiding this comment.
During your BOM refactoring, the session-examples broke - I haven't dug too deep, but this is the quick fix to get it back working.
niloc132
previously approved these changes
Dec 23, 2021
niloc132
approved these changes
Dec 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.