Followup to Paul's comments about debezium-demo over slack. #1932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments were:
===
Vs README_RPM.md
received_at_minute = lowerBin(received_at, minute_in_nanos)
profile_views
looks wrong from their perspective (they say last 5 users per profile, but are selecting 10).
pf2 = pageviews_stg.sort("target_id","received_at").tailBy(5, "target_id")
Column order is different
Some column names are different
Data type of lifetime_value is different (our BigDecimal vs. their int)
Otherwise, looks good
===
We discussed about data for dd_flagged_tables having to come from a curl invocation scripted in the README_RPM.md original. When Paul did that he found another issue related to the natural join in the definition for dd_flagged_profiles_view throwing an exception due to finding more than one right hand match; the solution is to change the operation from
naturalJoin
tojoin
.I addressed column order and simplifications suggested by Paul.