Simplify Input Table Interface. #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Dec 7, 2023
engine/table/src/main/java/io/deephaven/engine/util/config/MutableInputTable.java
Outdated
Show resolved
Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/util/AppendOnlyArrayBackedMutableTable.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/util/BaseArrayBackedMutableTable.java
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/util/KeyedArrayBackedMutableTable.java
Show resolved
Hide resolved
rcaudy
added
query engine
core
rcaudy
reviewed
Dec 8, 2023
| NullValueColumnSource.createColumnSourceMap(definition)); | ||
| final AppendOnlyArrayBackedMutableTable result = new AppendOnlyArrayBackedMutableTable( | ||
| initialTable.getDefinition(), new ProcessPendingUpdater()); | ||
| result.setAttribute(Table.ADD_ONLY_TABLE_ATTRIBUTE, Boolean.TRUE); |
There was a problem hiding this comment.
We should be setting append-only, too.
| initialTable.getDefinition(), new ProcessPendingUpdater()); | ||
| result.setAttribute(Table.ADD_ONLY_TABLE_ATTRIBUTE, Boolean.TRUE); | ||
| result.setFlat(); | ||
| processInitial(initialTable, result); |
There was a problem hiding this comment.
Why do we need to create or process an empty initial table? Also, could one of the make overloads delegate to the other?
| * <p> | ||
| * Implementations of this interface will make their own guarantees about how atomically changes will be applied and | ||
| * what operations they support. | ||
| */ | ||
| public interface MutableInputTable { | ||
| public interface InputTable { |
rcaudy
approved these changes
Dec 8, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/3528 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the InputTableEnumGetter and InputTableRowSetter interfaces that MutableInputTable extended, but are not used by web.
There have been the following class renames:
io.deephaven.engine.util.config.MutableInputTable -> io.deephaven.engine.util.input.InputTableHandler
KeyedArrayBackedMutableTable -> io.deephaven.engine.table.impl.util.KeyedArrayBackedInputTable
AppendOnlyArrayBackedMutableTable -> io.deephaven.engine.table.impl.util.AppendOnlyArrayBackedInputTable
Additionally, the MutableInputTable interface, KeyedArrayBackedMutableTable, and AppendOnlyArrayBackedMutableTable no longer have parameters for enum values. The "allowEdits" parameter has been removed from the interface and all implementations. The delete method that takes a rowSet has been removed.