Add some tools to use docker from gradle #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
reviewed
May 10, 2021
Comment on lines
329
to
330
| with self.subTest(msg="deliberate test failure"): | ||
| self.assertTrue(False) |
There was a problem hiding this comment.
Note to remove this before merge.
There was a problem hiding this comment.
But after we confirm that CI correctly fails, reports this
niloc132
force-pushed
the
430-python-tasks
branch
from
ee93654 to
44586a9
Compare
niloc132
force-pushed
the
430-python-tasks
branch
from
44586a9 to
cd0ae00
Compare
devinrsmith
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Docker class with some util methods to make it easier to perform some common docker operations. This patch uses them to replace some existing docker tasks with shorter configuration, and also rewrites some python tests, python doc gen to work without BUILD_PY set to true
Partial #430