Fail workflows if the unit test reports have failures #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
force-pushed
the
fail-on-xml-failures
branch
from
0be510d to
4ea7325
Compare
devinrsmith
force-pushed
the
fail-on-xml-failures
branch
from
4ea7325 to
ff658db
Compare
|
Here's an example where the check ci was failed on purpose: https://github.com/deephaven/deephaven-core/pull/560/checks?check_run_id=2555141729 - the new script caught the XML failure. |
devinrsmith
force-pushed
the
fail-on-xml-failures
branch
from
47c3ef3 to
ff658db
Compare
rcaudy
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we are relying on our publishing side to post failure annotations instead of the actual wokrflow itself failing out. The actual workflow failing is much preferred, as we have badges for them, and it provides more immediate and true feedback to the PRs.