Ensure generated formula code handles prev correctly for i,ii in ticking tables. Fixes #544 #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2021 21:29
…guments for calls to SortedRanges.invert. Towards deephaven#544.
|
My demo is working w/ this fix. |
kosak
previously approved these changes
May 13, 2021
rcaudy
requested changes
May 14, 2021
jcferretti
commented
May 16, 2021
DB/src/main/java/io/deephaven/db/v2/select/DhFormulaColumn.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
May 16, 2021
DB/src/main/java/io/deephaven/db/v2/select/DhFormulaColumn.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New unit test case that fails without this change added to QueryTableTest.
TestFormulaColumnGenerator ran and FormulaSample was generated, and tested.