Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add pyarrow date64/time64('ns') to the list of supported Arrow data types in the Python client #6048

Merged

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Sep 11, 2024

related to #6044

The DH server is now able to convert between Arrow date64/time64 and Java LocalDate/LocalTime. The Python client needs to include the mapping of these two types when building Arrow schema for uploading Arrow data to the server.

Copy link
Member

@nbauernfeind nbauernfeind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chipkent chipkent changed the title fix: Add pa date64/time64('ns') to the supported list fix: Add pyarrow date64/time64('ns') to the supported list Sep 23, 2024
@jmao-denver jmao-denver changed the title fix: Add pyarrow date64/time64('ns') to the supported list fix: Add pyarrow date64/time64('ns') to the list of supported Arrow data types in the Python client Sep 23, 2024
@jmao-denver jmao-denver merged commit 33d955e into deephaven:main Sep 25, 2024
28 checks passed
@jmao-denver jmao-denver deleted the 6044-add-supported-arrow-type branch September 25, 2024 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants