fix

deephaven · Oct 29, 2024 · 0ec34a7 · 0ec34a7
1 parent 327860a
commit 0ec34a7
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/plugins/ui/src/deephaven/ui/components/stack.py b/plugins/ui/src/deephaven/ui/components/stack.py
@@ -10,7 +10,7 @@ def stack(
     *children: Any,
     height: float | Undefined = UNDEFINED,
     width: float | Undefined = UNDEFINED,
-    activeItemIndex: int | Undefined = UNDEFINED,
+    active_item_index: int | Undefined = UNDEFINED,
     key: str | Undefined = UNDEFINED,
     **kwargs: Any,
 ) -> Element:

diff --git a/plugins/ui/test/deephaven/ui/test_date_range_picker.py b/plugins/ui/test/deephaven/ui/test_date_range_picker.py
@@ -14,6 +14,7 @@ def test_convert_date_range_picker_props(self):
             convert_list_prop,
             _convert_to_java_date,
         )
+        from deephaven.ui.types import UNDEFINED
 
         def verify_is_local_date(dateStr):
             self.assertEqual(
@@ -40,6 +41,7 @@ def empty_on_change():
             "default_value": {"start": "2021-01-01 ET", "end": "2021-01-02 ET"},
             "min_value": to_j_zdt("2021-01-01 ET"),
             "max_value": to_j_local_date("2021-01-01"),
+            "on_change": UNDEFINED,
         }
 
         props2 = {
@@ -53,6 +55,8 @@ def empty_on_change():
             },
             "placeholder_value": to_j_instant("2021-01-01 UTC"),
             "on_change": verify_is_local_date,
+            "min_value": UNDEFINED,
+            "max_value": UNDEFINED,
         }
 
         props3 = {
@@ -62,16 +66,37 @@ def empty_on_change():
             },
             "placeholder_value": to_j_zdt("2021-01-01 ET"),
             "on_change": verify_is_instant,
+            "value": UNDEFINED,
+            "min_value": UNDEFINED,
+            "max_value": UNDEFINED,
         }
 
         props4 = {
             "placeholder_value": to_j_zdt("2021-01-01 ET"),
             "on_change": verify_is_zdt,
+            "value": UNDEFINED,
+            "default_value": UNDEFINED,
+            "min_value": UNDEFINED,
+            "max_value": UNDEFINED,
         }
 
-        props5 = {"on_change": verify_is_instant}
+        props5 = {
+            "on_change": verify_is_instant,
+            "value": UNDEFINED,
+            "default_value": UNDEFINED,
+            "min_value": UNDEFINED,
+            "max_value": UNDEFINED,
+            "placeholder_value": UNDEFINED,
+        }
 
-        props6 = {"on_change": empty_on_change}
+        props6 = {
+            "on_change": empty_on_change,
+            "value": UNDEFINED,
+            "default_value": UNDEFINED,
+            "min_value": UNDEFINED,
+            "max_value": UNDEFINED,
+            "placeholder_value": UNDEFINED,
+        }
 
         _convert_date_range_picker_props(props1)
         _convert_date_range_picker_props(props2)