-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding maps #71
Conversation
Some examples:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need default colours applied to these maps before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open a ticket for default colours of maps. Should tie in with the current theme.
Ticket opened for default colours: deephaven/web-client-ui#1722 |
Closes #29, closes #28, closes #27, closes #26, and closes #21
Adds basic capabilities for all maps with the exception of choropleth
I originally was trying to include choropleths as well but they're a bit more complicated and I already have spent a bit too long on this for the moment. The other maps are basically free to implement.
There is a graphical issue with density mapbox that would be good for @mattrunyon to look at when adding the defaults. The data is there but not being drawn.
Here's some code to recreate the issue:
I see a ton of errors in the console, some along the line of "The layer 'plotly-trace-layer-ea2295-heatmap' does not exist in the map's style and cannot be styled."
Additionally, geo plots have the snapping issue when dragging when new data loads in that 3d plots had. Using the same imports: