Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ui.search_field #999

Merged
merged 7 commits into from
Nov 22, 2024
Merged

feat: ui.search_field #999

merged 7 commits into from
Nov 22, 2024

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Nov 8, 2024 •
edited
Loading

Closes #936
Closes #1006

@ethanalvizo ethanalvizo requested a review from mofojed November 8, 2024 03:49
@ethanalvizo ethanalvizo self-assigned this Nov 8, 2024
@ethanalvizo
Copy link
Contributor Author

Some quick examples to test the component

from deephaven import ui

disabled = ui.search_field(
    is_disabled=True,
)

label = ui.search_field(label="What do you want to look for", default_value="Search for a word")

on_clear = ui.search_field(on_clear=lambda: print("Input cleared"))

on_submit = ui.search_field(on_submit=lambda e: print(f"Value: {e}"))

@ethanalvizo
Copy link
Contributor Author

Markdown docs will be in a separate PR

@dsmmcken
Copy link
Contributor

dsmmcken commented Nov 8, 2024

I would put markdown in this PR please, docs should go in with features when we can

@mofojed
Copy link
Member

mofojed commented Nov 12, 2024

@ethanalvizo please open a PR to re-export the SearchField component before this: deephaven/web-client-ui#2287

mofojed
mofojed requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to push PR for deephaven/web-client-ui#2287

plugins/ui/src/js/src/elements/SearchField.tsx Outdated Show resolved Hide resolved
mofojed
mofojed requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small fixes

plugins/ui/docs/components/search_field.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/search_field.md Outdated Show resolved Hide resolved
dsmmcken
dsmmcken reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved docs, pending other reviewers.

margaretkennedy
margaretkennedy reviewed Nov 21, 2024
View reviewed changes
plugins/ui/docs/components/search_field.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/search_field.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/search_field.md Outdated Show resolved Hide resolved
mofojed
mofojed previously approved these changes Nov 21, 2024
View reviewed changes
@ethanalvizo @margaretkennedy
Grammar fixes
d605e83 
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
@ethanalvizo ethanalvizo merged commit 063f39a into deephaven:main Nov 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmmcken dsmmcken dsmmcken approved these changes

@mofojed mofojed mofojed left review comments

@margaretkennedy margaretkennedy Awaiting requested review from margaretkennedy

Assignees

@ethanalvizo ethanalvizo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: search_field ui.search_field
4 participants
@ethanalvizo @dsmmcken @mofojed @margaretkennedy