fix: Handling no columns (#1170)

Added graceful handling to IrisGrid for tables with no columns. fixes #1169
deephaven · Mar 22, 2023 · 2ac25ae · 2ac25ae
1 parent e314be6
commit 2ac25ae
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/packages/iris-grid/src/IrisGrid.test.tsx b/packages/iris-grid/src/IrisGrid.test.tsx
@@ -10,7 +10,7 @@ class MockPath2D {
   addPath = jest.fn();
 }
 
-window.Path2D = MockPath2D;
+window.Path2D = (MockPath2D as unknown) as new () => Path2D;
 
 const VIEW_SIZE = 5000;
 
@@ -61,7 +61,8 @@ function makeComponent(
       createNodeMock,
     }
   );
-  return testRenderer.getInstance();
+  return testRenderer.getInstance() as TestRenderer.ReactTestInstance &
+    IrisGrid;
 }
 
 function keyDown(key, component, extraArgs?) {
@@ -193,3 +194,15 @@ it('handles undefined operator, should default to eq', () => {
     'any'
   );
 });
+
+it('should set gotoValueSelectedColumnName to empty string if no columns are given', () => {
+  const component = makeComponent(
+    IrisGridTestUtils.makeModel(
+      IrisGridTestUtils.makeTable({
+        columns: [],
+      })
+    )
+  );
+
+  expect(component.state.gotoValueSelectedColumnName).toEqual('');
+});
diff --git a/packages/iris-grid/src/IrisGrid.tsx b/packages/iris-grid/src/IrisGrid.tsx
@@ -850,7 +850,7 @@ export class IrisGrid extends Component<IrisGridProps, IrisGridState> {
       gotoRowError: '',
       gotoValueError: '',
 
-      gotoValueSelectedColumnName: model.columns[0].name,
+      gotoValueSelectedColumnName: model.columns[0]?.name ?? '',
       gotoValueSelectedFilter: FilterType.eq,
       gotoValue: '',
       columnHeaderGroups: columnHeaderGroups ?? model.initialColumnHeaderGroups,