Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown when cell overflow position is unknown #1116

Closed
mofojed opened this issue Feb 27, 2023 · 0 comments · Fixed by #1177
Closed

Error thrown when cell overflow position is unknown #1116

mofojed opened this issue Feb 27, 2023 · 0 comments · Fixed by #1177
Assignees
@emilyhuxng
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
March 2023

Comments

@mofojed
Copy link
Member

mofojed commented Feb 27, 2023

Description

From failed test results on ticket DH-14152, there is sometimes an error thrown when hovering over a table. Tracking it down it was getting thrown in the asserts in IrisGridRenderer:

web-client-ui/packages/iris-grid/src/IrisGridRenderer.ts

Line 1016 in ffb7ada

assertNotNull(left);

Reading that code, it shouldn't assertNotNull, it should just return the NULL_POSITION if the grid cell coordinates cannot be found.

I am unsure of the steps to reproduce this from the front-end though.

Additional details and attachments
image
image
@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Feb 27, 2023
@vbabich vbabich added this to the March 2023 milestone Mar 1, 2023
@vbabich vbabich removed the triage Issue requires triage label Mar 1, 2023
@mofojed mofojed added the good first issue Good for newcomers label Mar 14, 2023
@emilyhuxng emilyhuxng self-assigned this Mar 27, 2023
@emilyhuxng emilyhuxng mentioned this issue Mar 27, 2023
Merged
emilyhuxng added a commit that referenced this issue Mar 27, 2023
@emilyhuxng
fix: Error thrown when cell overflow position is unknown (#1177)
bb24f61 
Fixes #1116 

Couldn't reproduce the bug but changed the code to return
`NULL_POSITION` if any needed values are undefined instead of using
`assertNotNull`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilyhuxng emilyhuxng

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

fix: Error thrown when cell overflow position is unknown emilyhuxng/web-client-ui
3 participants
@vbabich @mofojed @emilyhuxng