Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uncaught errors to support logs #1253

Closed
mattrunyon opened this issue Apr 27, 2023 · 1 comment · Fixed by #1293
Closed

Add uncaught errors to support logs #1253

mattrunyon opened this issue Apr 27, 2023 · 1 comment · Fixed by #1293
Assignees
@ethanalvizo
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
May 2023

Comments

@mattrunyon
Copy link
Collaborator

Right now, if the JS API throws an error, it might be uncaught and those don't seem to get added to the support logs because they bypass console.error. We should probably add a window level listener for uncaught errors and add them to the support logs
@mattrunyon mattrunyon added enhancement New feature or request triage Issue requires triage labels Apr 27, 2023
@vbabich vbabich added this to the May 2023 milestone May 3, 2023
@vbabich vbabich added good first issue Good for newcomers and removed triage Issue requires triage labels May 3, 2023
@mofojed mofojed assigned mofojed and ethanalvizo and unassigned mofojed May 5, 2023
@mofojed
Copy link
Member

mofojed commented May 9, 2023

Details on adding a window level listener for unhandled promise rejections: https://developer.mozilla.org/en-US/docs/Web/API/Window/unhandledrejection_event
And for error events: https://developer.mozilla.org/en-US/docs/Web/API/Window/error_event
Note that LogProxy already handles uncaught errors, so we just need to add the unhandled rejections listener similarly.

@ethanalvizo ethanalvizo mentioned this issue May 12, 2023
Merged
ethanalvizo added a commit that referenced this issue May 12, 2023
@ethanalvizo
feat: add uncaught rejections to support logs (#1293)
29ed459 
Closes #1253 

- sample output logs:
[console.txt](https://github.com/deephaven/web-client-ui/files/11466158/console.txt)
- search for "can't handle this - ethan"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanalvizo ethanalvizo

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

feat: add uncaught rejections to support logs ethanalvizo/web-client-ui
4 participants
@vbabich @mofojed @mattrunyon @ethanalvizo