Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout shift when closing the last column in a row #1268

Closed
mattrunyon opened this issue May 5, 2023 · 0 comments · Fixed by #2241
Closed

Layout shift when closing the last column in a row #1268

mattrunyon opened this issue May 5, 2023 · 0 comments · Fixed by #2241
Assignees
@mattrunyon
Labels
bug Something isn't working golden-layout
Milestone
Backlog

Comments

@mattrunyon
Copy link
Collaborator

Description

This only appears to happen when you close or move the last item in the right-most column in a row. There is a vertical layout shift. Also, the drop zones can be temporarily wrong. They show correctly, but if there are many items in the left column and you try to drag the item from the right column into the left, it will sometimes drop in the completely wrong place (I think this happens on page reload specifically)

Steps to reproduce

  1. Create a multi-row layout. Put multiple columns in the last row (I think it works w/ middle row too)
  2. Put only 1 item in the last column of the row
  3. Close or drag the tab

Expected results

No layout shift

Actual results

Layout shift. If you drop the item back into its own column where it originally was and re-drag, no further layout shift occurs. Resizing and then dragging again causes layout shift

Additional details and attachments

The shift looks like it's around the height of the header, but not always. Sometimes the shift is up and other times down.

Screen.Recording.2023-05-05.at.6.03.12.PM.mov

Versions

  • Web UI Version: 0.37.3
@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels May 5, 2023
@mattrunyon mattrunyon mentioned this issue May 5, 2023
Open
@vbabich vbabich added this to the Backlog milestone May 10, 2023
@vbabich vbabich removed the triage Issue requires triage label May 10, 2023
@mattrunyon mattrunyon self-assigned this Sep 30, 2024
@mattrunyon mattrunyon mentioned this issue Sep 30, 2024
Merged
mofojed pushed a commit to mofojed/web-client-ui that referenced this issue Dec 17, 2024
@mattrunyon @mofojed
fix: Layout shifts when opening and closing panels from a fresh state (…
9ddc3d4 
…deephaven#2241)

Fixes deephaven#1268

This mostly occurs when you have a relatively fresh state. There's a
video in the ticket, but if you have just 2 rows then this is frequently
triggered. Using incognito mode should give you a fresh state which is
affected by this bug.

This fixes both the vertical shift when you open a new panel type (open
a notebook from a fresh state or open a table from a fresh layout state)
and when you close the last panel in a stack (like in the ticket)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
bug Something isn't working golden-layout
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix: Layout shifts when opening and closing panels from a fresh state mattrunyon/web-client-ui
2 participants
@vbabich @mattrunyon