Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login page looks bad when narrow #1399

Closed
mofojed opened this issue Jul 6, 2023 · 0 comments · Fixed by #1428
Closed

Login page looks bad when narrow #1399

mofojed opened this issue Jul 6, 2023 · 0 comments · Fixed by #1428
Assignees
@dsmmcken
Labels
bug Something isn't working
Milestone
July 2023

Comments

@mofojed
Copy link
Member

mofojed commented Jul 6, 2023

Description
The pre-shared-key login page looks really bad when it's narrow.

Steps to reproduce

  1. Start up Deephaven with pre-shared key auth
  2. Open the Web UI without entering a token
  3. Resize the window to be very narrow

Expected results
3. Login page should resize gracefully, and look something like the following where the top and bottom line up:
image

Actual results
3. The top does not line up correctly with the bottom:
image

Versions

Engine Version: 0.26.0
Web UI Version: 0.42.0
Java Version: 11.0.19
Barrage Version: 0.6.0
@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Jul 6, 2023
@vbabich vbabich added this to the July 2023 milestone Jul 12, 2023
@vbabich vbabich removed the triage Issue requires triage label Jul 12, 2023
dsmmcken added a commit that referenced this issue Jul 31, 2023
@dsmmcken
Fixes #1399
3933b8d 
Add missing class prefix of modified login form.
@dsmmcken dsmmcken mentioned this issue Jul 31, 2023
Merged
mofojed pushed a commit that referenced this issue Aug 3, 2023
@dsmmcken
fix: login page looks bad when narrow (#1428)
6e0b60e 
Fixes #1399

Add missing class prefix of modified login form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsmmcken dsmmcken

Labels
bug Something isn't working
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

fix: login page looks bad when narrow deephaven/web-client-ui
3 participants
@dsmmcken @vbabich @mofojed