You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #1390 tree and rollup tables are not sortable.
The definition added to IrisGridTableModel should be in IrisGridTableModelTemplate because IrisGridTreeTableModel is using the default implementation which just always returns false.
We should also change the default to true probably since the engine should just fail the sort and tell the UI in those cases. According to this comment, the bug where the error was thrown instead of reported as a message to the UI is fixed, so should be fine to default to let the user try to sort (although the default implementation in IrisGridModel won't be hit in our uses)
Steps to reproduce
Create a tree or rollup table.
Try to sort a column that you would normally be able to sort
Expected results
Column sorts
Actual results
Column is not sortable in the UI
Versions
Engine Version: 0.26.0
Web UI Version: 0.44.0
The text was updated successfully, but these errors were encountered:
so should be fine to default to let the user try to sort
The point of marking columns as not sortable is that we can communicate that to the user if something is not sortable and disable the various ways to sort rather than just not do it. We should expect columns to be explicit from now on.
In cases where the API does not report if a column is sortable, I'm saying we should probably default to true (which this currently does, just not for tree tables). That is the least breaking path since before we said everything was sortable. Otherwise we will break enterprise until they implement the API (if they implement it even)
Description
After #1390 tree and rollup tables are not sortable.
The definition added to
IrisGridTableModel
should be inIrisGridTableModelTemplate
becauseIrisGridTreeTableModel
is using the default implementation which just always returns false.We should also change the default to true probably since the engine should just fail the sort and tell the UI in those cases. According to this comment, the bug where the error was thrown instead of reported as a message to the UI is fixed, so should be fine to default to let the user try to sort (although the default implementation in
IrisGridModel
won't be hit in our uses)Steps to reproduce
Expected results
Actual results
Versions
The text was updated successfully, but these errors were encountered: