Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree and rollup tables are not sortable #1402

Closed
mattrunyon opened this issue Jul 10, 2023 · 2 comments · Fixed by #1404
Closed

Tree and rollup tables are not sortable #1402

mattrunyon opened this issue Jul 10, 2023 · 2 comments · Fixed by #1404
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mattrunyon
Copy link
Collaborator

Description

After #1390 tree and rollup tables are not sortable.

The definition added to IrisGridTableModel should be in IrisGridTableModelTemplate because IrisGridTreeTableModel is using the default implementation which just always returns false.

We should also change the default to true probably since the engine should just fail the sort and tell the UI in those cases. According to this comment, the bug where the error was thrown instead of reported as a message to the UI is fixed, so should be fine to default to let the user try to sort (although the default implementation in IrisGridModel won't be hit in our uses)

Steps to reproduce

  1. Create a tree or rollup table.
  2. Try to sort a column that you would normally be able to sort

Expected results

  1. Column sorts

Actual results

  1. Column is not sortable in the UI

Versions

  • Engine Version: 0.26.0
  • Web UI Version: 0.44.0
@mattrunyon mattrunyon added the bug Something isn't working label Jul 10, 2023
@mattrunyon mattrunyon added this to the July 2023 milestone Jul 10, 2023
@dsmmcken
Copy link
Contributor

so should be fine to default to let the user try to sort

The point of marking columns as not sortable is that we can communicate that to the user if something is not sortable and disable the various ways to sort rather than just not do it. We should expect columns to be explicit from now on.

@mattrunyon
Copy link
Collaborator Author

In cases where the API does not report if a column is sortable, I'm saying we should probably default to true (which this currently does, just not for tree tables). That is the least breaking path since before we said everything was sortable. Otherwise we will break enterprise until they implement the API (if they implement it even)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants