Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run eslint / Prettier across codebase #1429

Closed
bmingles opened this issue Jul 31, 2023 · 0 comments · Fixed by #1430, #1431 or #1436
Closed

Run eslint / Prettier across codebase #1429

bmingles opened this issue Jul 31, 2023 · 0 comments · Fixed by #1430, #1431 or #1436
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui

Comments

@bmingles
Copy link
Contributor

As a developer, I'd like for codebase to be up to date with latest eslint + Prettier upgrades.
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Jul 31, 2023
@bmingles bmingles self-assigned this Jul 31, 2023
@bmingles bmingles added web-client-ui and removed triage Issue requires triage labels Jul 31, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jul 31, 2023
@bmingles
chore: eslint --fix across packages/*/src
ea60995 
deephaven#1429
@bmingles bmingles mentioned this issue Jul 31, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jul 31, 2023
@bmingles
chore: npx prettier packages/*/src --write
e028ced 
deephaven#1429

deephaven#1429
mofojed pushed a commit that referenced this issue Jul 31, 2023
@bmingles
chore: eslint --fix across packages/*/src (#1430)
0326d74 
I ran `npx prettier packages/*/src --write` to run Prettier on all src
files across packages.

I also ran `npm run lint:test` to confirm there are no more failing
tests.

resolves #1429
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 1, 2023
@bmingles
feat: Added .git-blame-ignore-revs
0e24c7e 
deephaven#1429
@bmingles bmingles mentioned this issue Aug 1, 2023
Merged
mofojed pushed a commit that referenced this issue Aug 1, 2023
@bmingles
feat: Added .git-blame-ignore-revs (#1431)
e3db6bf 
Added `.git-blame-ignore-revs` file containing Prettier formatting
revision.
resolves #1429
bmingles added a commit to bmingles/web-client-ui that referenced this issue Aug 2, 2023
@bmingles
chore: Disabled react/react-in-jsx-scope
52b6250 
deephaven#1429
@bmingles bmingles mentioned this issue Aug 2, 2023
Merged
bmingles added a commit that referenced this issue Aug 2, 2023
@bmingles
chore: Disabled react/react-in-jsx-scope (#1436)
630ed0c 
While migrating Enterprise to use our Community eslint rules, there
seemed to be only 1 additional rule used by Enterprise:
```json
"react/react-in-jsx-scope": "off"
```
I added it to the Community config.
resolves #1429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
No milestone
1 participant
@bmingles