Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep manually entered value in the GoToRow search when changing columns if the column type is the same #1562

Closed
vbabich opened this issue Oct 6, 2023 · 0 comments · Fixed by #1743
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vbabich
Copy link
Collaborator

vbabich commented Oct 6, 2023

Don't re-populate the GoToRow search when changing columns if it contains a manually entered value and the column type doesn't change.

@vbabich vbabich added bug Something isn't working triage Issue requires triage labels Oct 6, 2023
@vbabich vbabich added this to the October 2023 milestone Oct 10, 2023
@vbabich vbabich removed the triage Issue requires triage label Oct 10, 2023
@mofojed mofojed modified the milestones: October 2023, December 2023 Dec 4, 2023
@mofojed mofojed assigned wusteven815 and unassigned Zhou-Ziheng Jan 9, 2024
@mofojed mofojed modified the milestones: December 2023, January 2024 Jan 9, 2024
wusteven815 added a commit that referenced this issue Jan 25, 2024
…umn type (#1743)

- Fixes #1562 
  - Tracks if the value was manually entered and changes appropriately
  - Adds test with a wait to account for the debounce

**Testing Methodology**
- Generated a relevant table with 2 integer and 1 string columns
- GoToRow has a column selector and a field to input the value, the
possible configurations are
  - If the column selector has changed types
  - If the field was changed
- GoToRow should leave the field unmodified if the column selector has
changed types and the field was changed, otherwise keep the original
behaviour
- One special case where this is the case AND GoToRow has been toggled,
going back to the original behaviour
- Helper function `setColumnAndExpectInputValue` to make the changes and
do the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants