Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezing a column then sorting columns in the organize column results in wrong column frozen #1645

Closed
dsmmcken opened this issue Nov 15, 2023 · 0 comments · Fixed by #1749
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dsmmcken
Copy link
Contributor

Description

Freezing a column then sorting columns in the organize column results in wrong column frozen. After the user is also unable to unfreeze the wrongly frozen column.

Steps to reproduce

from deephaven import time_table

simple_ticking = time_table("PT00:00:01").update([
        "MyString=new String(`a`+i)",
        "MyInt=new Integer(i)",
        "MyLong=new Long(i)",
        "MyDouble=new Double(i+i/10)",
        "MyFloat=new Float(i+i/10)",
        "MyBoolean=new Boolean(i%2==0)",
        "MyChar= new Character((char) ((i%26)+97))",
        "MyShort=new Short(Integer.toString(i%32767))",
        "MyByte= new java.lang.Byte(Integer.toString(i%127))"])
  1. Right click the "MyFloat" column header, and select "Freeze column" from the context menu.
  2. Open the table overflow menu, and select organize columns, then press the sort ascending button
  3. (optional): attempt to unfreeze the frozen column (now MyBoolean)

Expected results
MyFloat remains frozen, and the other columns are sorted.

Actual results

MyBoolean becomes the frozen column, and no columns are shown as frozen as the organize columns list. Right clicking the "MyBoolean" column doesn't give an option to unfreeze it, only freeze which then freezes a completely different column.

Additional details and attachments

freeze_column

Versions

Engine Version: 0.31.0
Web UI Version: 0.54.0
Java Version: 21.0.1
Barrage Version: 0.6.0

@dsmmcken dsmmcken added bug Something isn't working triage Issue requires triage labels Nov 15, 2023
@dsmmcken dsmmcken changed the title Freezing a column then sorting columns in the organize column results in wrong column frozen. Freezing a column then sorting columns in the organize column results in wrong column frozen Nov 15, 2023
@vbabich vbabich added this to the December 2023 milestone Nov 21, 2023
@vbabich vbabich removed the triage Issue requires triage label Nov 21, 2023
@mofojed mofojed modified the milestones: December 2023, January 2024 Jan 9, 2024
@wusteven815 wusteven815 self-assigned this Jan 23, 2024
mofojed pushed a commit that referenced this issue Feb 7, 2024
- Fixes #1645 
- Moves are now generated for frozen columns (like front/end for initial
moved columns) and only used when sorting
- The range being sorted is truncated to remove frozen/front/end columns
- Added tests to make sure the sort is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants