-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConsolePanel should not render if there is no session #1684
Comments
This may actually be 2 separate bugs. I tried returning null from the component when the sessionWrapper is undefined. This got rid of the console error, but the session still persisted when logging out if a file is open. Closing the file and logging out works as expected. Created #1685 to address the failed logout. |
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Jan 11, 2024
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Jan 11, 2024
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Jan 19, 2024
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Jan 19, 2024
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Jan 19, 2024
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Jan 19, 2024
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Jan 19, 2024
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Jan 22, 2024
bmingles
added a commit
that referenced
this issue
Jan 22, 2024
- Handle undefined props on DashboardData. Don't render console panel if no session - Fixed a set state on unmounted HeapUsage bug - Removed chatty async interval debug logging fixes #1684 **Testing** - Run server with PSK enabled - Login and open any file - Logout should no longer show "ConsolePanel.tsx:372 Uncaught TypeError: Cannot destructure property 'config' of 'sessionWrapper' as it is undefined." error in debug console (Note that login will still fail until #1685 is done)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The
ConsolePanel
component has a connect prop tosessionWrapper
. If this prop is undefined / null, the component crashes when attempting to destructure the prop with an error "Cannot destructure property 'config' of 'sessionWrapper'". This component should not be rendered at all ifsessionWrapper
is undefined.Steps to reproduce
Expected results
There should be no console errors. Console should not be rendered if no session is available
Actual results
On login there is a console error "Cannot destructure property 'config' of 'sessionWrapper'". On logout, the same error occurs.
Additional details and attachments
Versions
Engine Version: 0.31.0-SNAPSHOT
Web UI Version: 0.56.0
Java Version: 21.0.1
Barrage Version: 0.6.0
The text was updated successfully, but these errors were encountered: