Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DH-16336: usePickerWithSelectedValues - boolean flags should be calculated based on trimmed search text #1747

Closed
bmingles opened this issue Jan 23, 2024 · 0 comments · Fixed by #1750
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bmingles
Copy link
Contributor

In support of DH-16336, the usePickerWithSelectedValues hook needs to be able to handle non-trimmed search text but to base its return boolean flags on the trimmed value (hasSearchTextWithZeroResults, searchTextExists, searchTextIsInSelectedValues). It might be best to configure this with an optional input arg or something so that the current behavior can also be supported.

@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Jan 23, 2024
@bmingles bmingles self-assigned this Jan 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jan 26, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jan 26, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jan 26, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jan 26, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jan 26, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jan 26, 2024
@vbabich vbabich removed the triage Issue requires triage label Jan 30, 2024
@vbabich vbabich added this to the January 2024 milestone Jan 30, 2024
bmingles added a commit that referenced this issue Jan 31, 2024
… calculated based on trimmed search text (#1750)

Supports DH-16336:
- Added an `isDebouncing` prop to `useDebouncedValue`
- Added support for search text trimming to
`usePickerWithSelectedValues`
- Introduced a validation delay to account for viewport filtering to
improve UX and avoid flicker of validation message

resolves #1747

Note that there's not any place in DHC that uses the
`usePickerWithSelectedValues` hook yet. I've been testing locally as
part of DH-16336.

BREAKING CHANGE: `usePickerWithSelectedValues` now takes an object as an
argument instead of positional args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants