Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncoalesced tables with no partitioning columns do not render #1763

Closed
devinrsmith opened this issue Jan 31, 2024 · 2 comments · Fixed by #1767
Closed

Uncoalesced tables with no partitioning columns do not render #1763

devinrsmith opened this issue Jan 31, 2024 · 2 comments · Fixed by #1767
Assignees
Labels
bug Something isn't working
Milestone

Comments

@devinrsmith
Copy link
Member

As of deephaven/deephaven-core#5078, the following code

from deephaven import parquet

x = parquet.read("my-file.parquet")
x_coalesced = x.coalesce()

no longer renders x in the UI - it just spins. x is of type io.deephaven.engine.table.impl.SimpleSourceTable, which is an uncoalesced table (with a single / implicit partition?).

@devinrsmith devinrsmith added bug Something isn't working triage Issue requires triage labels Jan 31, 2024
@rcaudy rcaudy changed the title io.deephaven.engine.table.impl.SimpleSourceTable does not render Uncoalesced tables with no partitioning columns do not render Feb 1, 2024
@mofojed mofojed self-assigned this Feb 1, 2024
@mofojed mofojed removed the triage Issue requires triage label Feb 1, 2024
@mofojed mofojed added this to the January 2024 milestone Feb 1, 2024
@mofojed
Copy link
Member

mofojed commented Feb 1, 2024

Reproducible using just this snippet:

from deephaven import parquet, new_table
parquet.write(new_table({"Foo": [1, 2, 3]}), "my-table.parquet")
x = parquet.read("my-table.parquet")

@rcaudy I want to confirm I'm fixing the right thing. So in the example above, the table isUncoalesced, but it has no partition columns. In that case, we're just supposed to fetch the whole table, correct? No partition selector?

mofojed added a commit to mofojed/web-client-ui that referenced this issue Feb 1, 2024
- When there are no partition columns, we should just load the whole table instead of hanging
- Tested with the snippet in the ticket
- Fixes deephaven#1763
@rcaudy
Copy link
Member

rcaudy commented Feb 1, 2024

Reproducible using just this snippet:

from deephaven import parquet, new_table
parquet.write(new_table({"Foo": [1, 2, 3]}), "my-table.parquet")
x = parquet.read("my-table.parquet")

@rcaudy I want to confirm I'm fixing the right thing. So in the example above, the table isUncoalesced, but it has no partition columns. In that case, we're just supposed to fetch the whole table, correct? No partition selector?

Yes, exactly. That's the only way to turn it into something you can render.

mofojed added a commit that referenced this issue Feb 1, 2024
…1767)

- When there are no partition columns, we should just load the whole
table instead of hanging
- Tested with the snippet in the ticket
- Fixes #1763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants