Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goto row button tooltips are flipped #1826

Closed
mattrunyon opened this issue Feb 22, 2024 · 0 comments · Fixed by #1860
Closed

Goto row button tooltips are flipped #1826

mattrunyon opened this issue Feb 22, 2024 · 0 comments · Fixed by #1860
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@mattrunyon
Copy link
Collaborator

Description

The up arrow tooltip says next match. The down arrow says previous match. That's reversed. Up arrow should say previous. Down should say next

Steps to reproduce

  1. Create a table
    from deephaven import empty_table
    t = empty_table(50).update(["X=ii", "Odd=X%2"])
  2. Open goto row with ctrl+g
  3. Hover the arrows for go to value

Expected results

  1. Up arrow says "Previous match". Down arrow says "Next match"

Actual results

  1. Up arrow says "Next match". Down arrow says "Previous match"

Additional details and attachments

The actual logic of the buttons is correct, just the tooltips that are incorrect.

@mattrunyon mattrunyon added bug Something isn't working good first issue Good for newcomers triage Issue requires triage labels Feb 22, 2024
@vbabich vbabich added this to the March 2024 milestone Feb 27, 2024
@vbabich vbabich removed the triage Issue requires triage label Feb 27, 2024
wusteven815 added a commit that referenced this issue Mar 12, 2024
- Fixes #1826 
  - Swap "Previous match" and "Next match"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants