-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Picker - initial scroll position #1942
Merged
bmingles
merged 30 commits into
deephaven:main
from
bmingles:1935-picker-initial-scroll
Apr 24, 2024
Merged
feat: Picker - initial scroll position #1942
bmingles
merged 30 commits into
deephaven:main
from
bmingles:1935-picker-initial-scroll
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
force-pushed
the
1935-picker-initial-scroll
branch
from
April 19, 2024 15:10
36fe15d
to
703268b
Compare
mofojed
reviewed
Apr 24, 2024
mofojed
reviewed
Apr 24, 2024
mofojed
reviewed
Apr 24, 2024
packages/components/src/spectrum/picker/usePickerScrollOnOpen.ts
Outdated
Show resolved
Hide resolved
mofojed
reviewed
Apr 24, 2024
mofojed
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor cleanup, otherwise looks good.
mofojed
approved these changes
Apr 24, 2024
bmingles
force-pushed
the
1935-picker-initial-scroll
branch
from
April 24, 2024 22:25
8ae77ea
to
1f37fde
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR depends on deephaven/deephaven-plugins#424 in order for element type checks to work for
Item
,Text
,Section
, etc.icon_column
#1890 should do the same for ListView, and we should be able to delete some of the normalization code)Testing
This illustrates different configurations and shows how initial scroll behavior differs for Pickers with plain items, descriptions, or sections:
resolves #1935