Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picker + ListView - icon_column #1890

Closed
bmingles opened this issue Mar 21, 2024 · 0 comments · Fixed by #1959 or deephaven/deephaven-core#5439
Closed

Picker + ListView - icon_column #1890

bmingles opened this issue Mar 21, 2024 · 0 comments · Fixed by #1959 or deephaven/deephaven-core#5439
Assignees
@bmingles

Comments

@bmingles
Copy link
Contributor

bmingles commented Mar 21, 2024 •
edited
Loading

Add support for icon_column

Description column support has been split off into #1958
@bmingles bmingles self-assigned this Mar 21, 2024
@mofojed mofojed changed the title Picker - description_column Picker - description_column and icon_column Mar 27, 2024
@mofojed mofojed mentioned this issue Mar 27, 2024
Merged
@bmingles bmingles changed the title Picker - description_column and icon_column Picker + ListView - description_column and icon_column Apr 2, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 12, 2024
@bmingles
Fixed ListView tooltip styling (deephaven#1890)
3082421
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 12, 2024
@bmingles
cleanup (deephaven#1890)
1b906fd
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 12, 2024
@bmingles
icon and description handling (deephaven#1890)
298a596
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 12, 2024
@bmingles
Item icon and description rendering (deephaven#1890)
5c07661
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 15, 2024
@bmingles
Started simplifying item normalization and rendering (deephaven#1890)
ce440da
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 15, 2024
@bmingles
ListView working with different children types (deephaven#1890)
08a4a9e
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 16, 2024
@bmingles
Added modules to index (deephaven#1890)
3392161
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 19, 2024
@bmingles
Fixed ListView tooltip styling (deephaven#1890)
9760a2d
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 19, 2024
@bmingles
cleanup (deephaven#1890)
bb6fbae
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 19, 2024
@bmingles
icon and description handling (deephaven#1890)
386f048
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 19, 2024
@bmingles
Item icon and description rendering (deephaven#1890)
574a2c8
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 19, 2024
@bmingles
Started simplifying item normalization and rendering (deephaven#1890)
363043e
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 19, 2024
@bmingles
ListView working with different children types (deephaven#1890)
af90c57
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 19, 2024
@bmingles
Added modules to index (deephaven#1890)
edb3d2a
@bmingles bmingles mentioned this issue Apr 22, 2024
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 23, 2024
@bmingles
Refactored listview (deephaven#1890)
d4d2d41
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 23, 2024
@bmingles
Updated styleguide (deephaven#1890)
e00fcfb
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 23, 2024
@bmingles
Removed unused normalization code (deephaven#1890)
95fb994
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 23, 2024
@bmingles
Icon and description column support (deephaven#1890)
ea7522c
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 23, 2024
@bmingles
Constraining listview icon height (deephaven#1890)
cfdde51
@bmingles bmingles mentioned this issue Apr 23, 2024
Open
@bmingles bmingles changed the title Picker + ListView - description_column and icon_column Picker + ListView - icon_column Apr 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 23, 2024
@bmingles
Disabling description support (deephaven#1890)
3cf75c1
@bmingles bmingles mentioned this issue Apr 23, 2024
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 23, 2024
@bmingles
Refactored icon heights to css vars (deephaven#1890)
6f22da6
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 23, 2024
@bmingles
Deleted icon height js (deephaven#1890)
b4cc52e
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Removed unused normalization code (deephaven#1890)
ca6a80d
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Icon and description column support (deephaven#1890)
35b7935
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Constraining listview icon height (deephaven#1890)
4ce1c16
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Disabling description support (deephaven#1890)
d290e68
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Refactored icon heights to css vars (deephaven#1890)
99abdc8
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Deleted icon height js (deephaven#1890)
a22cdff
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Added density to styleguide (deephaven#1890)
dfaaf8b
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
useRenderNormalizedItem tests (deephaven#1890)
912a64a
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
itemWrapperUtils tests (deephaven#1890)
26d1c7a
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
comment (deephaven#1890)
5306d2b
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Consolidated union (deephaven#1890)
b450090
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Fixed wrappeditems error (deephaven#1890)
6c1a83f
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
ensureArray util (deephaven#1890)
6a70bd9
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Removed descriptionColumn prop (deephaven#1890)
70a3539
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Fixed styleguide grid heights (deephaven#1890)
ddcd165
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Made listview icons smaller (deephaven#1890)
b184a27
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Fixed large scale in styleguide (deephaven#1890)
707c733
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Reorg props (deephaven#1890)
48341f5
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
separateSpectrumProps util (deephaven#1890)
a360e1f
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Removed content rect detection (deephaven#1890)
889186f
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Renamed var (deephaven#1890)
9ced845
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
Fixed ListView prop type (deephaven#1890)
c6cc36c
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 29, 2024
@bmingles
e2e snapshots (deephaven#1890)
c02cd50
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 30, 2024
@bmingles
Code review comments (deephaven#1890)
89aa1e0
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 30, 2024
@bmingles
Fixed styleguide crashing (deephaven#1890)
06617ed
bmingles added a commit that referenced this issue May 1, 2024
@bmingles @dsmmcken
feat: ListView + Picker - Item icon support (#1959)
cb13c60 
This example shows both basic and table data sources.
```python
import deephaven.ui as ui


@ui.component
def ui_list_view():
    value, set_value = ui.use_state(["Text 2"])

    text = ui.text("Selection: " + ", ".join(map(str, value)), grid_column="span 2")

    # list_view with text children
    lv = ui.list_view(
        "Text 1",
        "Text 2",
        "Text 3",
        # min_height=1,
        aria_label="List View",
        on_change=set_value,
        selected_keys=value,
    )

    # list_view with item children
    lv2 = ui.list_view(
        ui.item("Item 1", key="Text 1"),
        ui.item("Item 2", key="Text 2"),
        ui.item("Item 3", key="Text 3"),
        aria_label="List View 2",
        on_change=set_value,
        selected_keys=value,
    )
    
    return ui.grid(
        text,
        lv,
        lv2,
        columns="repeat(2, 1fr)",
        rows="min-content",
        height="100%"
    )


lv = ui_list_view()

####################################
import deephaven.ui as ui
from deephaven import time_table
import datetime

icon_names = ['vsAccount']

# Ticking table with initial row count of 200 that adds a row every second
initial_row_count=2000
columns = [
    "Id=new Integer(i)",
    "Display=new String(`Display `+i)",
    "Description=new String(`Description `+i)",
    "Icon=(String) icon_names[0]"
]
# column_types_ticking = time_table("PT1S", start_time=datetime.datetime.now() - datetime.timedelta(seconds=initial_row_count)).update([
#     columns
# )
column_types = empty_table(initial_row_count).update(columns)

@ui.component
def labeled_lv(label, *args, **kwargs):
    return ui.flex(
        ui.text(label),
        ui.list_view(
            *args,
            **kwargs
        ),
        direction="column",
        flex=1,
        min_width=0,
    )

@ui.component
def ui_list_view_table():
    value, set_value = ui.use_state([2, 4, 5])

    lv = labeled_lv(
        "Compact",
        column_types,
        max_height=5000,
        density="compact",
        key_column="Id",
        label_column="Display",
        icon_column="Icon",
        aria_label="List View",
        on_change=set_value,
        selected_keys=value,
    )

    lv2 = labeled_lv(
        "Regular",
        column_types,
        max_height=5000,
        density="regular",
        key_column="Id",
        label_column="Display",
        icon_column="Icon",
        aria_label="List View 2",
        on_change=set_value,
        selected_keys=value,
    )

    lv3 = labeled_lv(
        "Spacious",
        column_types,
        max_height=5000,
        density="spacious",
        key_column="Id",
        label_column="Display",
        icon_column="Icon",
        aria_label="List View 3",
        on_change=set_value,
        selected_keys=value,
    )

    text = ui.text("Selection: " + ", ".join(map(str, value)))

    return ui.flex(
        ui.flex(
            lv,
            lv2,
            lv3,
            direction="row",
            gap=10,
        ),
        text,
        direction="column",
    )

lv_table = ui_list_view_table()
```

resolves #1890

---------

Co-authored-by: Don McKenzie <donmckenzie@deephaven.io>
@mofojed mofojed mentioned this issue May 1, 2024
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue May 1, 2024
@github-actions @deephaven-internal
Update web version 0.75.0 (#5439)
3a34e5c 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.75.0

# [0.75.0](deephaven/web-client-ui@v0.74.0...v0.75.0) (2024-05-01)


### Bug Fixes

* change fira source ([#1944](deephaven/web-client-ui#1944)) ([07e5a26](deephaven/web-client-ui@07e5a26)), closes [#1902](deephaven/web-client-ui#1902)
* Fix null partition filter ([#1954](deephaven/web-client-ui#1954)) ([3a1f92b](deephaven/web-client-ui@3a1f92b)), closes [#1867](deephaven/web-client-ui#1867)


### Features

* context menu reopen for stack only ([#1932](deephaven/web-client-ui#1932)) ([6a9a6a4](deephaven/web-client-ui@6a9a6a4)), closes [#1931](deephaven/web-client-ui#1931)
* Create an ErrorView that can be used to display errors ([#1965](deephaven/web-client-ui#1965)) ([65ef1a7](deephaven/web-client-ui@65ef1a7))
* ListView + Picker - Item icon support ([#1959](deephaven/web-client-ui#1959)) ([cb13c60](deephaven/web-client-ui@cb13c60)), closes [#1890](deephaven/web-client-ui#1890)
* Picker - initial scroll position ([#1942](deephaven/web-client-ui#1942)) ([5f49761](deephaven/web-client-ui@5f49761)), closes [#1890](deephaven/web-client-ui#1890) [#1935](deephaven/web-client-ui#1935)

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
stanbrub pushed a commit to deephaven/deephaven-core that referenced this issue May 3, 2024
@github-actions @deephaven-internal @stanbrub
Update web version 0.75.0 (#5439)
41a93da 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.75.0

# [0.75.0](deephaven/web-client-ui@v0.74.0...v0.75.0) (2024-05-01)


### Bug Fixes

* change fira source ([#1944](deephaven/web-client-ui#1944)) ([07e5a26](deephaven/web-client-ui@07e5a26)), closes [#1902](deephaven/web-client-ui#1902)
* Fix null partition filter ([#1954](deephaven/web-client-ui#1954)) ([3a1f92b](deephaven/web-client-ui@3a1f92b)), closes [#1867](deephaven/web-client-ui#1867)


### Features

* context menu reopen for stack only ([#1932](deephaven/web-client-ui#1932)) ([6a9a6a4](deephaven/web-client-ui@6a9a6a4)), closes [#1931](deephaven/web-client-ui#1931)
* Create an ErrorView that can be used to display errors ([#1965](deephaven/web-client-ui#1965)) ([65ef1a7](deephaven/web-client-ui@65ef1a7))
* ListView + Picker - Item icon support ([#1959](deephaven/web-client-ui#1959)) ([cb13c60](deephaven/web-client-ui@cb13c60)), closes [#1890](deephaven/web-client-ui#1890)
* Picker - initial scroll position ([#1942](deephaven/web-client-ui#1942)) ([5f49761](deephaven/web-client-ui@5f49761)), closes [#1890](deephaven/web-client-ui#1890) [#1935](deephaven/web-client-ui#1935)

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bmingles