Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export Spectrum ButtonGroup and make dh Button compatible #2016

Closed
bmingles opened this issue May 14, 2024 · 0 comments · Fixed by #2028
Closed

Re-export Spectrum ButtonGroup and make dh Button compatible #2016

bmingles opened this issue May 14, 2024 · 0 comments · Fixed by #2028
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bmingles
Copy link
Contributor

We want to re-export Spectrum's ButtonGroup from @deephaven/components, however, We are not planning to re-export Spectrum's Button, so we need to make it compatible with Spectrum's ButtonGroup

  • Apply Spectrum styling to DH Button via useSlotProps hook
  • Re-export Spectrum ButtonGroup

e.g. We should be able to add something like this to our Button component.

const { UNSAFE_className } = useSlotProps<{ UNSAFE_className?: string }>(
  {},
  'button'
);

...
<button
  ...
  className={classNames(
     ...
     className,
     UNSAFE_className
  )}
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels May 14, 2024
@bmingles bmingles self-assigned this May 14, 2024
@vbabich vbabich removed the triage Issue requires triage label May 21, 2024
@vbabich vbabich added this to the May 2024 milestone May 21, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2024
bmingles added a commit that referenced this issue May 24, 2024
- Added Spectrum ButtonGroup support to DH Button
- Re-exported Spectrum ButtonGroup

resolves #2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants