Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command History gets really slow when >1000 items #325

Closed
mofojed opened this issue Dec 2, 2021 · 2 comments · Fixed by #1145
Closed

Command History gets really slow when >1000 items #325

mofojed opened this issue Dec 2, 2021 · 2 comments · Fixed by #1145
Assignees
@bmingles
Labels
bug Something isn't working web-client-ui
Milestone
March 2023

Comments

@mofojed
Copy link
Member

mofojed commented Dec 2, 2021

Description

When there are lots of items in the command history (more than 1000) it gets really slow when scrolling

Steps to reproduce

  1. Add >1000 items to command history
  2. Scroll up and down quickly

Expected results
2. Able to see command history quickly

Actual results
2. Shows a blank screen when scrolling, takes a few seconds for the information to appear
@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Dec 2, 2021
@mofojed mofojed self-assigned this Dec 2, 2021
@mofojed mofojed added this to the February 2022 milestone Feb 2, 2022
@mofojed mofojed removed the triage Issue requires triage label Feb 2, 2022
@mofojed mofojed modified the milestones: February 2022, March 2022 Mar 1, 2022
@mofojed mofojed modified the milestones: March 2022, April 2022 Apr 5, 2022
@mofojed mofojed modified the milestones: April 2022, May 2022 May 2, 2022
@vbabich vbabich modified the milestones: May 2022, June 2022 Jun 1, 2022
@mofojed mofojed modified the milestones: June 2022, July 2022 Jul 5, 2022
@mofojed mofojed modified the milestones: July 2022, August 2022 Jul 25, 2022
@mofojed mofojed modified the milestones: August 2022, September 2022 Sep 9, 2022
@mofojed mofojed modified the milestones: September 2022, October 2022 Oct 3, 2022
This was referenced Oct 7, 2022
Closed
Closed
@mofojed mofojed modified the milestones: October 2022, November 2022 Nov 16, 2022
@mofojed mofojed modified the milestones: November 2022, December 2022 Dec 5, 2022
mofojed added a commit to mofojed/web-client-ui that referenced this issue Dec 28, 2022
@mofojed
Fix issue with old buttons not getting disabled in console history
0852a4e 
- We were mutating objects within the state, violating the immutability principle.
- Clone any object that we were mutating.
- Cleaned up some of the code.
- All tests pass
- Tested by running the steps in the description of deephaven#325, also tested importing a CSV and giving it the same name as a prior object. Old objects were updated correctly.
- Fixes deephaven#325
@mofojed mofojed mentioned this issue Dec 28, 2022
Merged
@mofojed
Copy link
Member Author

mofojed commented Feb 27, 2023

When deephaven-core has persistence, we could implement command history server side rather than storing in the browser locally (with PouchDB). However, that persistence is not currently roadmapped so is not coming any time soon.

In the meantime, we should look at what is causing the performance to be so slow with just a few thousand items. I find it surprising that this can't be handled quickly within the browsers local storage.

@mofojed
Copy link
Member Author

mofojed commented Mar 6, 2023

Investigate why it is slow, then decide whether we need to just truncate the CommandHistory at some time.

@mofojed mofojed modified the milestones: February 2023, March 2023 Mar 8, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 9, 2023
@bmingles
Added smarter caching for command history fetching
17b8c60 
[deephaven#325]
@bmingles bmingles mentioned this issue Mar 9, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 9, 2023
@bmingles
Added smarter caching for command history fetching
0dfc815 
[deephaven#325]

[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 9, 2023
@bmingles
Added smarter caching for command history fetching
3c0ce54 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 10, 2023
@bmingles
Optimized PouchDB access for command history
5e8db06 
fixes deephaven#325

[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 13, 2023
@bmingles
Cleaned up PouchCommandHistoryTable
24027fd 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 13, 2023
@bmingles
Added smarter caching for command history fetching
bce44fb 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 13, 2023
@bmingles
Optimized PouchDB access for command history
aa940ad 
fixes deephaven#325

[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 13, 2023
@bmingles
Cleaned up PouchCommandHistoryTable
b9a89ea 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 13, 2023
@bmingles
PouchDB pruning
7d85d92 
Added logic to "prune" db if it gets too large

[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 14, 2023
@bmingles
Added ability to disable change notifications
401e7bc 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 14, 2023
@bmingles
Split out the static cache into separate module
d45fec6 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 14, 2023
@bmingles
Fixed an issue with table subscriptions persisting
c2566d5 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 15, 2023
@bmingles
Converted cache to non-static
c76b345 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 15, 2023
@bmingles
Fixed race conditions
b96228b 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 15, 2023
@bmingles
Comment fixes
bc76a9c 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 15, 2023
@bmingles
Cleanup
1bd31ca 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 15, 2023
@bmingles
Fixed dbOptions type
a69a737 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 16, 2023
@bmingles
Added sorting to fetchViewportData
1306a3f 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 16, 2023
@bmingles
Moved debounce int CommandHistoryViewportUpdater
9a57842 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 16, 2023
@bmingles
withTimeout tests
5581e60 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 17, 2023
@bmingles
Lowered debounce timeout
19b0a60 
[deephaven#325]
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 17, 2023
@bmingles
Fixed small pruning bug
5c0b541 
[deephaven#325]
bmingles added a commit that referenced this issue Mar 17, 2023
@bmingles
fix: Added smarter caching for command history fetching (#1145)
76b3bd5 
I've tested this with 72,000 total records in the PouchDB (70K marked as
deleted + 2-2.5K active).

When 2,000 non-deleted records are present, I bulk insert 500 records.
This gets the count up to 2,500 documents. If I push 1 more, the pruning
behavior kicks in and marks the oldest 501 as deleted resulting in 2,000
active documents.

Fixes #325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working web-client-ui
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

fix: Added smarter caching for command history fetching bmingles/web-client-ui
3 participants
@bmingles @vbabich @mofojed