refactor: TypeScript Type Improvements

[Zhou-Ziheng]

There are certain types that needs to be improved as part of the Enterprise TypeScript conversion.
This PR aims to contain all changes that needs to be made.

Fixes #1122
BREAKING CHANGE: Selector Type removed from redux

[codecov]

Codecov Report

Merging #1056 (b958c9d) into main (a60bda5) will decrease coverage by 0.01%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
- Coverage   43.46%   43.46%   -0.01%     
==========================================
  Files         437      437              
  Lines       32951    32954       +3     
  Branches     8305     8309       +4     
==========================================
  Hits        14323    14323              
- Misses      18579    18582       +3     
  Partials       49       49              

Flag	Coverage Δ
unit	43.46% <43.75%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/chart/src/ChartModelFactory.ts	76.92% <ø> (ø)
packages/code-studio/src/main/WidgetUtils.ts	5.55% <0.00%> (ø)
...udio/src/settings/ColumnSpecificSectionContent.tsx	98.72% <ø> (-0.01%)	⬇️
...e-studio/src/settings/FormattingSectionContent.tsx	63.11% <ø> (ø)
.../dashboard-core-plugins/src/ChartBuilderPlugin.tsx	0.00% <0.00%> (ø)
packages/dashboard/src/layout/LayoutUtils.ts	13.94% <0.00%> (ø)
packages/iris-grid/src/IrisGridUtils.ts	54.09% <ø> (ø)
packages/chart/src/ChartUtils.ts	64.19% <42.85%> (-0.23%)	⬇️
packages/code-studio/src/redux/selectors.ts	50.00% <50.00%> (ø)
...ackages/code-studio/src/settings/SettingsUtils.tsx	92.10% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mofojed]

If you want to make sure this doesn't get merged, you can click "Convert to Draft" under the reviewers section to mark it as a draft.

[mofojed]

@Zhou-Ziheng can you rebase this off the latest and mark this as "Ready for review" if it is ready for review?

[mofojed]

I think would be cleaner to do Partial<TableColumnFormat>

[mofojed]

@Zhou-Ziheng also update the PR description to put "Fixes #1122" in the description, and change the Breaking notice to match the format we're expecting (e.g. "BREAKING CHANGE: Selector type removed from redux"

[mofojed]

I don't really like what's going on here with removeFormatRuleExtraProps and isFormatRuleValidForSave.
Instead, we should define a ValidFormatterItem type as well, so something like:

export type ValidFormatterItem = FormattingRule & {
  id?: number;
  isNewRule?: boolean;
};

export type FormatterItem = ValidFormatterItem & {
  format: Partial<TableColumnFormat>;
};

So it makes it a little more clear what constitutes an "invalid" FormatterItem.
Then these functions just become:

function removeFormatRuleExtraProps(item: ValidFormatterItem): FormattingRule;

function isFormatRuleValidForSave(rule: FormatterItem): rule is ValidFormatterItem;

I think that makes it a little clearer what's going on.