Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Conventional Commits for release management/PRs #1057

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jan 29, 2023

  • Update web-client-ui repository to use Conventional Commits instead of the labelling system we have been using for release management.
  • Remove the label check GitHub action/script; we no longer require labels to be added
  • Remove Create Release action - the version bump/release creation process will be kicked off locally instead of by a GitHub action
  • Add GitHub action to enforce conventional commit PR titles
  • Update CONTRIBUTING guidelines to detail rules for creating a PR
  • Update README to detail how to update release
  • Pin the version of ubuntu in all GitHub actions

- Remove the label check GitHub action/script; we no longer require labels to be added
- Remove `Create Release` action - the version bump/release creation process will be kicked off locally instead of by a GitHub action
- Add GitHub action to enforce conventional commit PR titles
- Update README and CONTRIBUTING guidelines to detail rules for creating a PR, and how to update release
- Pin the version of ubuntu in all GitHub actions
@mofojed mofojed added this to the January 2023 milestone Jan 29, 2023
@mofojed mofojed requested review from vbabich and mattrunyon January 29, 2023 19:57
@mofojed mofojed self-assigned this Jan 29, 2023
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #1057 (893a246) into main (073f8f5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files         430      430           
  Lines       32342    32341    -1     
  Branches     8125     8127    +2     
=======================================
  Hits        13578    13578           
+ Misses      18711    18710    -1     
  Partials       53       53           
Flag Coverage Δ
unit 41.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/code-studio/src/main/AppMainContainer.tsx 31.92% <0.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

README.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
- Should match the old doc-labels name so we don't need to change infra
@mofojed mofojed requested a review from mattrunyon January 30, 2023 21:05
CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/workflows/conventional-pr-check.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit approve instead of request when I mentioned Don's comment

- Makes it easier to consume rather than having to read the provided link
- More accurate name
- Will update required checks after merge
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for readme change

@mofojed mofojed modified the milestones: January 2023, February 2023 Jan 31, 2023
@mofojed mofojed merged commit aeaf940 into deephaven:main Feb 1, 2023
@mofojed mofojed deleted the conventional-commits-enforcement branch February 1, 2023 22:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants