Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase code coverage in package jsapi-utils #1114

Conversation

emilyhuxng
Copy link
Contributor

@emilyhuxng emilyhuxng commented Feb 27, 2023

Closes #1096

Increase code coverage in package jsapi-utils

@emilyhuxng emilyhuxng self-assigned this Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1114 (0c8fb0f) into main (0be0850) will increase coverage by 1.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   43.46%   44.48%   +1.01%     
==========================================
  Files         437      437              
  Lines       32954    32944      -10     
  Branches     8309     8304       -5     
==========================================
+ Hits        14323    14654     +331     
+ Misses      18582    18241     -341     
  Partials       49       49              
Flag Coverage Δ
unit 44.48% <100.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...api-utils/src/formatters/BooleanColumnFormatter.ts 100.00% <ø> (+100.00%) ⬆️
packages/jsapi-utils/src/TableUtils.ts 87.12% <100.00%> (+33.68%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emilyhuxng emilyhuxng requested a review from mofojed March 10, 2023 16:28
@emilyhuxng emilyhuxng marked this pull request as ready for review March 10, 2023 16:58
__mocks__/dh-core.js Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
packages/jsapi-utils/src/TableUtils.test.ts Outdated Show resolved Hide resolved
@emilyhuxng emilyhuxng requested a review from mofojed March 13, 2023 20:52
@emilyhuxng emilyhuxng merged commit 362928f into deephaven:main Mar 14, 2023
@emilyhuxng emilyhuxng deleted the increase-code-coverage-in-package-jsapi-utils branch March 14, 2023 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code coverage in package jsapi-utils
2 participants