Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drag to re-arrange custom columns not working (#1299) #1302

Merged
merged 1 commit into from
May 16, 2023

Conversation

dsmmcken
Copy link
Contributor

resolves: #1282

Broken by #1013. Can't use prop spreading with our Button component,
added support for spreading.
Needs silverheels cherry-pick.

resolves: #1282

Broken by #1013. Can't use prop spreading with our Button component,
added support for spreading.
Needs silverheels cherry-pick.
@dsmmcken dsmmcken requested a review from mofojed May 16, 2023 19:51
@dsmmcken dsmmcken self-assigned this May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #1302 (79ca688) into release/v0.31 (0e3eb2c) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/v0.31    #1302   +/-   ##
==============================================
  Coverage          43.44%   43.44%           
==============================================
  Files                436      436           
  Lines              32757    32757           
  Branches            8272     8272           
==============================================
  Hits               14232    14232           
  Misses             18476    18476           
  Partials              49       49           
Flag Coverage Δ
unit 43.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/components/src/Button.tsx 76.31% <ø> (ø)

@dsmmcken dsmmcken merged commit 0984632 into release/v0.31 May 16, 2023
@dsmmcken dsmmcken deleted the dmckenzie_cherry_pick_1299 branch May 16, 2023 21:00
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
@dsmmcken
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants