Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add a default DashboardPanelWrapper #1346

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jun 2, 2023

- Fixes an issue introduced with deephaven#1329
- Wasn't using a stable function as the default wrapper function
@mofojed mofojed requested a review from mattrunyon June 2, 2023 15:34
@mofojed mofojed self-assigned this Jun 2, 2023
@mofojed mofojed enabled auto-merge (squash) June 2, 2023 15:41
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #1346 (42f6a0a) into main (210908c) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1346      +/-   ##
==========================================
- Coverage   45.95%   45.94%   -0.01%     
==========================================
  Files         493      494       +1     
  Lines       34414    34416       +2     
  Branches     8582     8582              
==========================================
  Hits        15814    15814              
- Misses      18549    18551       +2     
  Partials       51       51              
Flag Coverage Δ
unit 45.94% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/dashboard/src/DashboardPanelWrapper.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/DashboardLayout.tsx 47.32% <100.00%> (ø)

@mofojed mofojed merged commit ddd92cf into deephaven:main Jun 2, 2023
@mofojed mofojed deleted the panel-wrapper-fix branch June 2, 2023 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants