Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests for rollup rows and aggregate columns #1350

Merged
merged 41 commits into from
Jun 8, 2023

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Jun 6, 2023

Closes #1344
Closes #1345
Closes #1331

@ethanalvizo ethanalvizo self-assigned this Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1350 (d6a8a4b) into main (b086e9c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1350   +/-   ##
=======================================
  Coverage   45.95%   45.95%           
=======================================
  Files         494      494           
  Lines       34422    34423    +1     
  Branches     8587     8587           
=======================================
+ Hits        15817    15820    +3     
+ Misses      18554    18552    -2     
  Partials       51       51           
Flag Coverage Δ
unit 45.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

packages/iris-grid/src/IrisGrid.tsx Outdated Show resolved Hide resolved
tests/table.spec.ts Outdated Show resolved Hide resolved
tests/table.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
panelAbove,
dropIndicator,
0,
browser === 'webkit' ? 1000 : undefined
Copy link
Contributor Author

@ethanalvizo ethanalvizo Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still couldn't figure out the work around for custom column. The coordinates that it was being dragged to looked correct so I don't think it was the same issue that we saw yesterday where it was out of the page bounds because the menu animation didn't finish for rollup rows. Can I mark this as a TODO and create a ticket for it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes mark TODO, add a ticket, and attach a video of a run that's failing where it looks correct.

@ethanalvizo ethanalvizo requested a review from mofojed June 8, 2023 08:18
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just some minor cleanup and adding the TODO then let's move on

tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
tests/table-operations.spec.ts Outdated Show resolved Hide resolved
panelAbove,
dropIndicator,
0,
browser === 'webkit' ? 1000 : undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes mark TODO, add a ticket, and attach a video of a run that's failing where it looks correct.

@ethanalvizo ethanalvizo enabled auto-merge (squash) June 8, 2023 16:39
@ethanalvizo ethanalvizo merged commit 5e0db54 into deephaven:main Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Test: Aggregate Columns E2E Test: Rollup Rows e2e snapshots should be linux only
2 participants