-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e tests for rollup rows and aggregate columns #1350
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1350 +/- ##
=======================================
Coverage 45.95% 45.95%
=======================================
Files 494 494
Lines 34422 34423 +1
Branches 8587 8587
=======================================
+ Hits 15817 15820 +3
+ Misses 18554 18552 -2
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. |
....spec.ts-snapshots/tests-complex-table-operations-can-organize-columns-1-chromium-darwin.png
Outdated
Show resolved
Hide resolved
panelAbove, | ||
dropIndicator, | ||
0, | ||
browser === 'webkit' ? 1000 : undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still couldn't figure out the work around for custom column. The coordinates that it was being dragged to looked correct so I don't think it was the same issue that we saw yesterday where it was out of the page bounds because the menu animation didn't finish for rollup rows. Can I mark this as a TODO and create a ticket for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes mark TODO, add a ticket, and attach a video of a run that's failing where it looks correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, just some minor cleanup and adding the TODO then let's move on
panelAbove, | ||
dropIndicator, | ||
0, | ||
browser === 'webkit' ? 1000 : undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes mark TODO, add a ticket, and attach a video of a run that's failing where it looks correct.
Closes #1344
Closes #1345
Closes #1331