Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stuck to bottom on filter clear #1579

Merged
merged 7 commits into from
Oct 27, 2023

Conversation

ethanalvizo
Copy link
Contributor

Closes #1477

Previous comments are in #1571 PR.

Note: Once this PR is merged #1571 can go in as well

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4eda17c) 46.48% compared to head (e42f72b) 46.74%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
+ Coverage   46.48%   46.74%   +0.26%     
==========================================
  Files         571      583      +12     
  Lines       36011    36262     +251     
  Branches     9012     9072      +60     
==========================================
+ Hits        16738    16951     +213     
- Misses      19221    19259      +38     
  Partials       52       52              
Flag Coverage Δ
unit 46.74% <83.33%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/grid/src/Grid.tsx 64.43% <87.50%> (-0.07%) ⬇️
...kages/grid/src/key-handlers/SelectionKeyHandler.ts 67.59% <75.00%> (+0.36%) ⬆️

... and 70 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/grid/src/Grid.tsx Outdated Show resolved Hide resolved
@ethanalvizo ethanalvizo requested a review from mofojed October 20, 2023 05:23
packages/grid/src/key-handlers/SelectionKeyHandler.ts Outdated Show resolved Hide resolved
packages/grid/src/key-handlers/SelectionKeyHandler.ts Outdated Show resolved Hide resolved
packages/grid/src/Grid.tsx Outdated Show resolved Hide resolved
@ethanalvizo ethanalvizo requested a review from mofojed October 26, 2023 04:36
@ethanalvizo ethanalvizo requested a review from mofojed October 27, 2023 05:40
@ethanalvizo ethanalvizo merged commit ef52749 into deephaven:main Oct 27, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isStuckToBottom behaviour when filtering
2 participants