Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: View cell contents in context menu #1657

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat: View cell contents in context menu #1657

merged 2 commits into from
Nov 27, 2023

Conversation

dsmmcken
Copy link
Contributor

Resolves #1605

@dsmmcken dsmmcken requested a review from mofojed November 24, 2023 16:44
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6083173) 46.58% compared to head (f6614c6) 46.58%.

Files Patch % Lines
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   46.58%   46.58%   -0.01%     
==========================================
  Files         597      597              
  Lines       36525    36529       +4     
  Branches     9144     9144              
==========================================
+ Hits        17015    17016       +1     
- Misses      19458    19461       +3     
  Partials       52       52              
Flag Coverage Δ
unit 46.58% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The signature for getCellActions could be improved (modelColumn can't be null/undefined, it's not even using grid, and it gets the modelRow again even though it's only called from a spot where we already know modelRow is not null), but none of that is part of your change.

@dsmmcken dsmmcken merged commit 90b7517 into main Nov 27, 2023
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_view_cell branch November 27, 2023 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"View full contents" for text cells should be available from context menu
2 participants