-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Theming - Spectrum variable mapping and light theme #1680
Merged
mofojed
merged 30 commits into
deephaven:main
from
bmingles:1669-spectrum-theme-variables
Dec 22, 2023
Merged
feat: Theming - Spectrum variable mapping and light theme #1680
mofojed
merged 30 commits into
deephaven:main
from
bmingles:1669-spectrum-theme-variables
Dec 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1680 +/- ##
==========================================
+ Coverage 46.67% 46.69% +0.02%
==========================================
Files 606 608 +2
Lines 36873 36913 +40
Branches 9267 9279 +12
==========================================
+ Hits 17211 17238 +27
- Misses 19610 19623 +13
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
force-pushed
the
1669-spectrum-theme-variables
branch
from
December 12, 2023 20:00
013533d
to
7bf0f29
Compare
dsmmcken
reviewed
Dec 14, 2023
dsmmcken
changed the title
feat: Theming - Spectrum variable mapping
feat: Theming - Spectrum variable mapping and light theme
Dec 21, 2023
mofojed
approved these changes
Dec 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theming - Spectrum variable mapping
resolves #1669
resolves #1539